🌱 Enforce non-empty validation to sysprep fullname and orgname

[brito-rafa]

What does this PR do, and why is it needed?

We are handling the ComputerName for inlined Guest OS Customization (GOSC) and FullName and OrgName are required fields.

Which issue(s) is/are addressed by this PR? (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #

Are there any special notes for your reviewer:

This is my first PR ever on this project. Happy to receive feedback and criticism.

Please add a release note if necessary:

Due to the requirements of Sysprep GOSC customization, when using inlined Sysprep bootstrapping, the UserData.FullName and UserData.OrgName are required fields.

[github-actions]

Package	Line Rate	Health
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/clustercontentlibraryitem	67%	❌
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/contentlibraryitem	67%	❌
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/utils	46%	❌
github.com/vmware-tanzu/vm-operator/controllers/infra/capability/configmap	92%	✔
github.com/vmware-tanzu/vm-operator/controllers/infra/capability/crd	100%	✔
github.com/vmware-tanzu/vm-operator/controllers/infra/configmap	75%	❌
github.com/vmware-tanzu/vm-operator/controllers/infra/node	77%	❌
github.com/vmware-tanzu/vm-operator/controllers/infra/secret	76%	❌
github.com/vmware-tanzu/vm-operator/controllers/infra/validatingwebhookconfiguration	87%	➖
github.com/vmware-tanzu/vm-operator/controllers/infra/zone	73%	❌
github.com/vmware-tanzu/vm-operator/controllers/storage/storageclass	93%	✔
github.com/vmware-tanzu/vm-operator/controllers/storage/storagepolicy	96%	✔
github.com/vmware-tanzu/vm-operator/controllers/storage/storagepolicyquota	91%	✔
github.com/vmware-tanzu/vm-operator/controllers/util/encoding	73%	❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/storagepolicyusage	96%	✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/virtualmachine	68%	❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/volume	85%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/volumebatch	89%	✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass	73%	❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinegroup	89%	✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinegrouppublishrequest	88%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineimagecache	88%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest	83%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinereplicaset	68%	❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice	83%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/providers	92%	✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy	81%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesnapshot	92%	✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest	72%	❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1	72%	❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions	88%	➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch	78%	❌
github.com/vmware-tanzu/vm-operator/controllers/vspherepolicy/policyevaluation	85%	➖
github.com/vmware-tanzu/vm-operator/pkg/bitmask	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/builder	93%	✔
github.com/vmware-tanzu/vm-operator/pkg/conditions	90%	✔
github.com/vmware-tanzu/vm-operator/pkg/config	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/config/capabilities	98%	✔
github.com/vmware-tanzu/vm-operator/pkg/config/env	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/context	35%	❌
github.com/vmware-tanzu/vm-operator/pkg/context/generic	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/context/operation	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/crd	76%	❌
github.com/vmware-tanzu/vm-operator/pkg/errors	76%	❌
github.com/vmware-tanzu/vm-operator/pkg/exit	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/log	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/mem	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/patch	78%	❌
github.com/vmware-tanzu/vm-operator/pkg/prober	89%	➖
github.com/vmware-tanzu/vm-operator/pkg/prober/probe	90%	✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker	77%	❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere	75%	❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/clustermodules	73%	❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config	88%	➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/contentlibrary	76%	❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/credentials	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/network	82%	➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/placement	69%	❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/session	52%	❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/storage	44%	❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/upgrade/virtualmachine	96%	✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vcenter	85%	➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine	86%	➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vmlifecycle	73%	❌
github.com/vmware-tanzu/vm-operator/pkg/record	87%	➖
github.com/vmware-tanzu/vm-operator/pkg/topology	91%	✔
github.com/vmware-tanzu/vm-operator/pkg/util	78%	❌
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit	89%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate	91%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/image	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube	91%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/cource	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/internal	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/proxyaddr	73%	❌
github.com/vmware-tanzu/vm-operator/pkg/util/kube/spq	99%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/linuxprep	97%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/netplan	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/nil	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache	75%	❌
github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache/internal	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/paused	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/ptr	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/resize	98%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/sysprep	98%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/vmopv1	90%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/volumes	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client	66%	❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/datastore	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/library	95%	✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/storage	84%	➖
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm	79%	❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/watcher	85%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig	95%	✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/anno2extraconfig	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/bootoptions	88%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/cdrom	88%	➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/crypto	91%	✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/diskpromo	100%	✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/policy	96%	✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/virtualcontroller	93%	✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/volumes/unmanaged/backfill	98%	✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/volumes/unmanaged/register	95%	✔
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation	100%	✔
github.com/vmware-tanzu/vm-operator/services/vm-watcher	85%	➖
github.com/vmware-tanzu/vm-operator/webhooks/common	98%	✔
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation	95%	✔
github.com/vmware-tanzu/vm-operator/webhooks/unifiedstoragequota/validation	89%	➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/mutation	87%	➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/validation	94%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/mutation	62%	❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/validation	89%	➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegroup/mutation	87%	➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegroup/validation	92%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegrouppublishrequest/mutation	86%	➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegrouppublishrequest/validation	88%	➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/validation	93%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinereplicaset/validation	90%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/mutation	67%	❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/validation	92%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/validation	89%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesnapshot/mutation	83%	➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesnapshot/validation	91%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation	92%	✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/validation	92%	✔
Summary	83% (18480 / 22331)	➖

Minimum allowed line rate is 79%