✨ Use ConfigSpec for all tag association / removal#1469
Open
aruneshpa wants to merge 1 commit intovmware-tanzu:mainfrom
Open
✨ Use ConfigSpec for all tag association / removal#1469aruneshpa wants to merge 1 commit intovmware-tanzu:mainfrom
aruneshpa wants to merge 1 commit intovmware-tanzu:mainfrom
Conversation
Historically, we relied on a combination of ConfigSpec (for new VMs) and tagging VAPIs (for existing VMs) to associate / remove tags from VMs when a policy was matched with a VM. This was because only CreateVM supported specifying tags during VM creation. There was no way to specify tags in a ConfigSpec using the Reconfigure API call. Since then, Reconfigure API has been enhanced to support this. This change modifies our code to use that. This allows an additional optimization that a single CreateVM / Reconfigure API call can now apply the tags as well as update the ExtraConfig that we maintain for book keeping of tags applied by VM Operator. Testing Done: - Created a mandatory policy that specified a tag - Validated that in steady state when the VM is matched / unmatched with that policy tag association and removal happens via Reconfigure.
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Historically, we relied on a combination of ConfigSpec (for new VMs) and tagging VAPIs (for existing VMs) to associate / remove tags from VMs when a policy was matched with a VM. This was because only CreateVM supported specifying tags during VM creation. There was no way to specify tags in a ConfigSpec using the Reconfigure API call.
Since then, Reconfigure API has been enhanced to support this. This change modifies our code to use that. This allows an additional optimization that a single CreateVM / Reconfigure API call can now apply the tags as well as update the ExtraConfig that we maintain for book keeping of tags applied by VM Operator.
Testing Done:
Please add a release note if necessary: