This repository was archived by the owner on Mar 2, 2022. It is now read-only.
Add missing --network-plugin parameter #184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unclear why the kubelet no longer set this parameter by default, but it is necessary for installs and upgrades. Adding it to the /etc/kubelet/default file. Signed-off-by: Craig Tracey <craigtracey@gmail.com>
alexbrand
approved these changes
May 9, 2019
Contributor
alexbrand
left a comment
alexbrand
left a comment
There was a problem hiding this comment.
LGTM. Do we need to cherry-pick forward?
Contributor
|
I wonder if there is a deeper problem when upgrading from v1.10 to v1.11: Based on that issue, it looks like when doing an upgrade the |
Contributor
|
Chatted with @craigtracey and we believe this is good to merge. |
Contributor
|
Can we close this PR, since 1.11.x is no longer a supported/maintained release? Or have we confirmed that we need this change in newer branches/releases? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear why the kubelet no longer set this parameter by default,
but it is necessary for installs and upgrades. Adding it to the
/etc/kubelet/default file.
Signed-off-by: Craig Tracey craigtracey@gmail.com