Skip to content
This repository was archived by the owner on Mar 15, 2021. It is now read-only.

Conversation

@tompscanlan
Copy link
Contributor

add systemd start up configuration for liota

(os.path.abspath(os.sep) + '/../etc/liota/packages/edge_systems/dell5k',
['packages/edge_systems/dell5k/edge_system.py']),
(os.path.abspath(os.sep) + '/../etc/liota/scripts',
(os.path.abspath(os.sep) + '/../etc/liota/scripts',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new dependencies in Manifest.in file

ExecStart=/etc/liota/packages/liotad.py

[Install]
WantedBy=multi-user.target No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I`m not sure but I think better to add a new line in both the files liotad.service & liotad.socket

http://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

@tompscanlan
Copy link
Contributor Author

Fixed endlines and added deps to the manifest file

README.md Outdated
### On systemd based systems:

```bash
$ systemctl enable liota.socket
Copy link
Contributor

@KohliDev KohliDev Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be liotad.service & liotad.socket?

Also, I cloned your branch and will try out this commands on Fedora VM. What is the prime job of these commands? Also, I think if liota daemon gets started then we won`t require liotad.socket to be started explicitly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tompscanlan

It'll be very helpful if you can provide some information about this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. Fixing that.

Copy link
Contributor

@KohliDev KohliDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tompscanlan Can you please answer the questions marked in the pull request?

@KohliDev
Copy link
Contributor

@tompscanlan any update on this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants