Improve performance, migrate tests to testify, expand test coverage#22
Open
sergeyfast wants to merge 2 commits intomasterfrom
Open
Improve performance, migrate tests to testify, expand test coverage#22sergeyfast wants to merge 2 commits intomasterfrom
sergeyfast wants to merge 2 commits intomasterfrom
Conversation
sergeyfast
commented
Feb 13, 2026
sergeyfast
commented
- Server hot-path optimization: fast path for single requests without wrapping into an array, replaced unicode.IsSpace with direct byte comparison in IsArray, replaced strings.SplitN with strings.Cut, optimized ConvertToObject with pre-allocated buffer
- PackageInfo.String() optimization: replaced string concatenation with strings.Builder
- Test framework migration from goconvey to testify: replaced github.com/smartystreets/goconvey with github.com/stretchr/testify (assert/require) across all test files
- Expanded test coverage: added unit tests for JSON-RPC 2.0 spec compliance (ID formats, version validation, batch/params edge cases), response structure tests, concurrency tests, context function tests, Error/Response API tests
- Added benchmarks: IsArray, ConvertToObject, Do() (single/batch/notification/error), ServeHTTP (sequential/parallel), middleware overhead
- Makefile: added -race flag to test target, added bench target
- README: fixed code examples (pointer receivers, removed dependency on testdata package)
- Server hot-path optimization: fast path for single requests without wrapping into an array, replaced unicode.IsSpace with direct byte comparison in IsArray, replaced strings.SplitN with strings.Cut, optimized ConvertToObject with pre-allocated buffer - PackageInfo.String() optimization: replaced string concatenation with strings.Builder - Test framework migration from goconvey to testify: replaced github.com/smartystreets/goconvey with github.com/stretchr/testify (assert/require) across all test files - Expanded test coverage: added unit tests for JSON-RPC 2.0 spec compliance (ID formats, version validation, batch/params edge cases), response structure tests, concurrency tests, context function tests, Error/Response API tests - Added benchmarks: IsArray, ConvertToObject, Do() (single/batch/notification/error), ServeHTTP (sequential/parallel), middleware overhead - Makefile: added -race flag to test target, added bench target - README: fixed code examples (pointer receivers, removed dependency on testdata package)
sergeyfast
commented
Feb 13, 2026
server.go
Outdated
|
|
||
| if req.ID == nil { | ||
| // notification — fire and forget | ||
| s.processRequest(ctx, req) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.