Skip to content

Conversation

@lushengguo
Copy link

AMQP::Address cannot correctly parse url when password contains '@', randomly generated password always contains this character

eg: AMQP::Address(amqp:://admin:admin@123@127.0.0.1:5672/).hostname() will be 123@127.0.0.1

@vmitkov
Copy link
Owner

vmitkov commented Aug 15, 2024

Thanks for the offer. I'd prefer to make another ctor for this case. I'll do it soon.
I'd also leave the ctor parameter "AMQP::Address address" instead of "AMQP::Address&& address" since that allows the "address" parameter to be used as both an l-value and an r-value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants