Bugfix: Include base_config.json in built wheel distribution#154
Bugfix: Include base_config.json in built wheel distribution#154vmenger merged 1 commit intovmenger:mainfrom
Conversation
|
@vmenger Would you have some time to look at this PR? |
|
@vmenger it would be nice if this could be merged soon, the current ugly workaround is to copy the file and you will get funky "fixes" like this one, which will need to be removed later again: https://github.com/Carmenda-nl/carmenda_pseudonymize_core/pull/40/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R21 It is a very small PR that should take very little time to review, but has a big impact in the usability of the tool! |
|
@d-hage I just signed in after some absence, it's on my todo list now, and will look into it soon! |
|
@d-hage Just merged and released 3.0.6, seems to fix it. Still a bit confused why this broke and why the tests in the release pipeline didn't find it. But thanks for helping out anyway! |
|
Thanks for addressing this so quickly after coming back from your time off!
I think it is because of some update in poetry-core, I don't think it was ever intended to work this way, as this adds the file to |
Description
This PR fixes an issue where
base_config.jsonwas not included in the built wheel since version 3.0.4, causing runtime errors. The file is now moved to within the deduce source directory, ensuring it is present in both sdist and wheel distributions. Simultaneously, this prevents this file to live in the broadersite-packagesdirectory in your environment but instead is insite-packages/deduce.This fixes #151
Similarly, I got the following error when experimenting with the package:
PR checlist
Verify that tests are passing ✅
Verify that tests are updated/added according to changes ✅ (Not needed)
Run the formatters (make format) ✅
Run the linters (make lint) ✅
Add a section to the changelog ✅
Add a description to your PR ✅