Button student allow up #305
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed f-string formatting without variables and in logging functions (vmck#266) * Removed f-string formatting in logger functions * Removed f-string formatting for strings without variables * fix coding style * Recomputes total score when the soft deadline changes (vmck#268) * Recomputes total score when the soft deadline changes * Update testsuite/test_ta_workflow.py Co-authored-by: Baruta Daniel Mihai <baruta.mihai99@gmail.com> Co-authored-by: Baruta Daniel Mihai <baruta.mihai99@gmail.com> * fix coding style * New state ERROR for submission update method (vmck#270) * Add CONTRIB.md (vmck#267) * Add CONTRIB.md * bold * add try / except to update method and create STATE_ERROR * add debug message * unit test WIP * update try catch implementation * update update_state method if statement * update update_state method tests * update submission state Co-authored-by: Baruta Daniel Mihai <baruta.mihai@yahoo.com> * coding style * Replace asserts (vmck#269) * Add CONTRIB.md (vmck#267) * Add CONTRIB.md * bold * Replace asserts * Tweak done call to return an HTTP 400 response instead * Run flake8 and black Co-authored-by: Baruta Daniel Mihai <baruta.mihai@yahoo.com> * move options to pyproject.toml * use postgres in dev and tests * black * flake8 * black * improve postgres.sh * Add sleep * improve postgres.sh * Fix test ta workflow * Add vault * Enable tests * Disable tests * use absoulte path * Root media * waitress * Add fix Signed-off-by: George Muraru <murarugeorgec@gmail.com> * GitHub actions (vmck#277) * Github Actions * Format the project * Fix state * Change order for submission state change * Remove save to storage process * Save storage * Profiler * Remove assignment * Start with debug * Remove profiler * Create migration for Error state * Update README (vmck#281) * Check only Running subs (vmck#280) * Check only running submissions * Fix flake/black * Change default state * Change default state * make migration Co-authored-by: Baruta Daniel Mihail <baruta.mihai@yahoo.com> * Profiler (vmck#284) * Use silk * Fix assignment page * Profiler on env & add shellcheck * Pytest in actions * Pagination for assignment * Pagination for user page * enable tests * update tests * Use silk * Fix assignment page * Profiler on env & add shellcheck * Pytest in actions * Pagination for assignment * Pagination for user page * enable tests * update tests * remove stupid * Add badge * use codecov script * Add unify config (vmck#255) * Add unify config * Fix flake * Fix fixtures * Fix name * Fix deadlines * Holiday must be a list Holiday must be a list * Add unify config * Fix flake * Fix fixtures * Fix name * Fix deadlines * Holiday must be a list Holiday must be a list * Add default * Holiday fix * Tests fix Co-authored-by: Baruta Daniel Mihail <baruta.mihai@yahoo.com> * st * Disable profiling while testing in the CI * Improve queries * Improve queries * Add log * Fix name * Fix name * Add GZIP Middleware * Remove bad select_related * Dockerhub on github actions * Add more logs (vmck#288) * Add more logs * Add exception * Add parameter when sending model * Fix param * Keep sub in memory (vmck#289) * Add in memory waitqueue * Create set * Add hash for sub * Fix black * Add try catch * Add save fields * Remove history * Fix Moss (vmck#291) * Add moss buffer * github actions update Co-authored-by: Baruta Daniel Mihail <baruta.mihai@yahoo.com> * Add hide button for assignments (vmck#295) Everything is fine! 👯 * Jw refactor homepage (vmck#296) * Dropdown * Dev (vmck#285) * Removed f-string formatting without variables and in logging functions (vmck#266) * Removed f-string formatting in logger functions * Removed f-string formatting for strings without variables * fix coding style * Recomputes total score when the soft deadline changes (vmck#268) * Recomputes total score when the soft deadline changes * Update testsuite/test_ta_workflow.py Co-authored-by: Baruta Daniel Mihai <baruta.mihai99@gmail.com> Co-authored-by: Baruta Daniel Mihai <baruta.mihai99@gmail.com> * fix coding style * New state ERROR for submission update method (vmck#270) * Add CONTRIB.md (vmck#267) * Add CONTRIB.md * bold * add try / except to update method and create STATE_ERROR * add debug message * unit test WIP * update try catch implementation * update update_state method if statement * update update_state method tests * update submission state Co-authored-by: Baruta Daniel Mihai <baruta.mihai@yahoo.com> * coding style * Replace asserts (vmck#269) * Add CONTRIB.md (vmck#267) * Add CONTRIB.md * bold * Replace asserts * Tweak done call to return an HTTP 400 response instead * Run flake8 and black Co-authored-by: Baruta Daniel Mihai <baruta.mihai@yahoo.com> * move options to pyproject.toml * use postgres in dev and tests * black * flake8 * black * improve postgres.sh * Add sleep * improve postgres.sh * Fix test ta workflow * Add vault * Enable tests * Disable tests * use absoulte path * Root media * waitress * Add fix Signed-off-by: George Muraru <murarugeorgec@gmail.com> * GitHub actions (vmck#277) * Github Actions * Format the project * Fix state * Change order for submission state change * Remove save to storage process * Save storage * Profiler * Remove assignment * Start with debug * Remove profiler * Create migration for Error state * Update README (vmck#281) * Check only Running subs (vmck#280) * Check only running submissions * Fix flake/black * Change default state * Change default state * make migration Co-authored-by: Baruta Daniel Mihail <baruta.mihai@yahoo.com> * Profiler (vmck#284) * Use silk * Fix assignment page * Profiler on env & add shellcheck * Pytest in actions * Pagination for assignment * Pagination for user page * enable tests * update tests * Use silk * Fix assignment page * Profiler on env & add shellcheck * Pytest in actions * Pagination for assignment * Pagination for user page * enable tests * update tests * remove stupid * Add badge * use codecov script * Add unify config (vmck#255) * Add unify config * Fix flake * Fix fixtures * Fix name * Fix deadlines * Holiday must be a list Holiday must be a list * Add unify config * Fix flake * Fix fixtures * Fix name * Fix deadlines * Holiday must be a list Holiday must be a list * Add default * Holiday fix * Tests fix Co-authored-by: Baruta Daniel Mihail <baruta.mihai@yahoo.com> * st * Disable profiling while testing in the CI * Improve queries * Improve queries * Add log * Fix name * Fix name * Add GZIP Middleware * Remove bad select_related * Dockerhub on github actions * Add more logs (vmck#288) * Add more logs * Add exception * Add parameter when sending model * Fix param * Keep sub in memory (vmck#289) * Add in memory waitqueue * Create set * Add hash for sub * Fix black * Add try catch * Add save fields * Remove history Co-authored-by: ptrstr <57736901+ptrstr@users.noreply.github.com> Co-authored-by: José Clovis Ramírez de la Rosa <clovis.ramirez@toptal.com> Co-authored-by: Guillaume <guillaume.falourd@zup.com.br> Co-authored-by: George Muraru <murarugeorgec@gmail.com> Co-authored-by: Sebika <44608549+sebika@users.noreply.github.com> * Final merge * Fix test * Remove redefinition Co-authored-by: ptrstr <57736901+ptrstr@users.noreply.github.com> Co-authored-by: José Clovis Ramírez de la Rosa <clovis.ramirez@toptal.com> Co-authored-by: Guillaume <guillaume.falourd@zup.com.br> Co-authored-by: George Muraru <murarugeorgec@gmail.com> Co-authored-by: Sebika <44608549+sebika@users.noreply.github.com> * Remove duplicate clean * Add ignore for moss (vmck#300) Co-authored-by: ptrstr <57736901+ptrstr@users.noreply.github.com> Co-authored-by: José Clovis Ramírez de la Rosa <clovis.ramirez@toptal.com> Co-authored-by: Guillaume <guillaume.falourd@zup.com.br> Co-authored-by: George Muraru <murarugeorgec@gmail.com> Co-authored-by: Sebika <44608549+sebika@users.noreply.github.com>
button students allow upload
Jokeswar
requested changes
Mar 13, 2021
| <li> | ||
| {{ assignment.name }}: | ||
| {% if assignment.is_active %} | ||
| {% if assignment.is_active and assignment.assignment_on or assignment.is_active and user in assignment.course.teaching_assistants.all %} |
Contributor
There was a problem hiding this comment.
It might not be enough just to hide the upload button. Students could still find the url to the upload page for this assignment and use it. A check in the upload view is still necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add button for allowing students to upload
Fixes #275
Testing
Checklist