Add support for static member functions and static properties#5
Open
Ghabry wants to merge 3 commits intovmanucharyan:masterfrom
Open
Add support for static member functions and static properties#5Ghabry wants to merge 3 commits intovmanucharyan:masterfrom
Ghabry wants to merge 3 commits intovmanucharyan:masterfrom
Conversation
Owner
|
Hi! Thanks for contribution! Could you, please, also add some tests for this? |
Contributor
|
I want that feature too! |
Author
|
Okay I will try to make up a few tests. |
Owner
|
@Ghabry I think one high level test for property and one for static method will be enough (just check that it is callable from js). lower level logic such as passing around arguments and return values is already tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I'm not completely sure if PushConstructorInspector is a good place for the code but this adds support for static member functions and properties.
The syntax matches the i.method and i.property functions:
I used "static_"-prefix to make the difference more visual clear because this prevents unintentional bugs.