Skip to content

[Bugfix] Fix issues in quark emulative logic #36486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangjiaxin99 wants to merge 3 commits into from
+6 −4
Closed

[Bugfix] Fix issues in quark emulative logic #36486

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7afc862
Correcting the emulate logic
Mar 9, 2026
9f9fe9d
Fix pre-commit issues
Mar 9, 2026
2425b9f
Merge branch 'main' into jiaxwang/correct_emulate_logic
wangjiaxin99 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions vllm/model_executor/layers/quantization/quark/quark_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,10 +730,12 @@ def __init__(
get_current_vllm_config().model_config.hf_config, "model_type", None
)

self.emulate = (
not current_platform.supports_mx()
or not self.ocp_mx_scheme.startswith("w_mxfp4")
) and (self.mxfp4_backend is None or not self.use_rocm_aiter_moe)
self.emulate = not (
current_platform.supports_mx()
and self.ocp_mx_scheme.startswith("w_mxfp4")
and self.mxfp4_backend is not None
and self.use_rocm_aiter_moe
)

# CK's pre-compiled MXFP4 MoE GEMM kernel instances have dimension
# alignment requirements. When violated (e.g. MiniMax-M2.1 with
Expand Down