AMD MI300X/MI325X/MI355X support for Qwen3.5 Model#271
AMD MI300X/MI325X/MI355X support for Qwen3.5 Model#271ajith-sirra-amd wants to merge 3 commits intovllm-project:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the support for AMD GPUs (MI300X, MI325X, MI355X) when deploying the Qwen3.5 model. It integrates comprehensive instructions for both pip and Docker-based installations, updates verification notes to include AMD hardware, and provides specific deployment configurations for MI355X nodes. The changes aim to make the Qwen3.5 model more accessible and performant on AMD's latest GPU architectures. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds valuable documentation for supporting Qwen3.5 on AMD MI300 series GPUs, including new installation and deployment instructions. The changes are well-structured, separating instructions for different hardware vendors. I have identified a couple of areas for improvement. The Docker command for AMD is incomplete, as it drops the user into a shell without further guidance; I've suggested a more user-friendly, complete command. Additionally, I found a typo in a command-line flag (-dp instead of -tp) in the MI355X deployment example, which would prevent the command from running correctly, and I have provided a fix.
Note: Security Review has been skipped due to the limited scope of the PR.
Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: ajith-sirra-amd <122240613+ajith-sirra-amd@users.noreply.github.com> Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: ajith-sirra-amd <122240613+ajith-sirra-amd@users.noreply.github.com> Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
998e07a to
f198f39
Compare
Summary
Add comprehensive AMD MI300X/MI325X/MI355X GPU support for Qwen3.5 deployment, including installation methods, Docker setup, and deployment configurations.
Changes
Installation Instructions
Docker Support
GPU Verification
MI355X Deployment
AMD-specific Notes