Update gpt-oss mi300,mi325,mi355 for vllm 0.17.0#268
Update gpt-oss mi300,mi325,mi355 for vllm 0.17.0#268Rohan138 wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Rohan138 <rohanpotdar138@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the GPT-OSS documentation to align with the latest vLLM 0.17.0 release, providing revised configurations and serving commands for enhanced performance on AMD GPUs. The changes introduce new environment variables and command-line arguments, along with an example for a quantized model, ensuring users can leverage the most current optimizations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the vLLM configurations for MI300, MI325, and MI355 to align with the vLLM 0.17.0 release. The changes include updating the validated release version, introducing new environment variables like AMDGCN_USE_BUFFER_OPS=0, and modifying vllm serve command arguments to incorporate new compilation flags and attention backend settings. Additionally, the default model for MI355x has been updated to a Quark-quantized version. One inconsistency was noted regarding the async-scheduling flag.
Note: Security Review has been skipped due to the limited scope of the PR.
| export VLLM_ROCM_QUICK_REDUCE_QUANTIZATION=INT4 | ||
|
|
||
| vllm serve openai/gpt-oss-120b --tensor-parallel-size=8 --gpu-memory-utilization 0.95 --compilation-config '{"cudagraph_mode": "FULL_AND_PIECEWISE"}' --block-size=64 --disable-log-request --async-scheduling | ||
| vllm serve amd/gpt-oss-120b-w-mxfp4-a-fp8 --tensor-parallel-size=8 --attention-backend ROCM_AITER_UNIFIED_ATTN -cc.pass_config.fuse_rope_kvcache=True -cc.use_inductor_graph_partition=True --gpu-memory-utilization 0.95 --block-size=64 |
There was a problem hiding this comment.
The vllm serve command for MI355x no longer includes the --async-scheduling flag. However, the "Configs and Parameters" section (line 316) still recommends always adding this flag for best performance. Please clarify if --async-scheduling is no longer recommended or implicitly handled for MI355x with vLLM 0.17.0, or if it should be re-included in this command for consistency with the general recommendation.
|
@Rohan138 |
See related PR: SemiAnalysisAI/InferenceX#867, will be merged after vllm 0.17.0 is released