Update Qwen3-VL.md vLLM version and YaRN parameters#237
Update Qwen3-VL.md vLLM version and YaRN parameters#237darsh12 wants to merge 1 commit intovllm-project:mainfrom
Conversation
Update vLLM version and YaRN parameters in documentation Update the --rope-scaling parameter to use --hf-override from vllm>=0.11.1 vllm-project/vllm#5205 vllm-project/vllm#29026 Signed-off-by: darsh12 <darsh12@users.noreply.github.com>
Summary of ChangesHello @darsh12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Qwen3-VL documentation to align with recent changes in the vLLM library. It ensures that users are directed to install a compatible vLLM version and use the correct parameter syntax for advanced features like YaRN context window extension, maintaining the accuracy and usability of the provided instructions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully updates the documentation for Qwen3-VL usage. It correctly reflects the new minimum vLLM version (0.11.1) and adapts the YaRN parameter passing method from --rope-scaling to --hf-overrides, aligning with the changes in vLLM's API. The updates are clear and necessary for compatibility, as indicated by the linked vLLM issues. The changes improve the accuracy and usability of the guide.
Update vLLM version and YaRN parameters in documentation
Update the --rope-scaling parameter to use --hf-override from vllm>=0.11.1
vllm-project/vllm#5205
vllm-project/vllm#29026