Remove stream-interval from config in GPT OSS Recipe#194
Remove stream-interval from config in GPT OSS Recipe#194rnik12 wants to merge 2 commits intovllm-project:mainfrom
Conversation
stream-interval breaks split between "reasoning_content" and "content"
Summary of ChangesHello @rnik12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a configuration problem within the GPT OSS Recipe. By removing a specific Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the stream-interval setting from two configuration examples in the GPT-OSS.md guide to fix a content splitting issue. While this is a good fix, the change is incomplete. It introduces inconsistencies as the actual YAML configuration files are not updated, other examples in the same document still use the parameter, and the documentation text still recommends it. My review comment provides details on the required changes to make this PR consistent and complete.
stream-interval breaks split between "reasoning_content" and "content"
removing stream-interval from the config restores the split between "reasoning_content" and "content"