Skip to content

Update Qwen3-Coder-480B-A35B.md for AMD GPU#160

Open
haic0 wants to merge 5 commits intovllm-project:mainfrom
haic0:patch-18
Open

Update Qwen3-Coder-480B-A35B.md for AMD GPU#160
haic0 wants to merge 5 commits intovllm-project:mainfrom
haic0:patch-18

Conversation

@haic0
Copy link
Contributor

@haic0 haic0 commented Dec 11, 2025

No description provided.

Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @haic0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the documentation for the Qwen3-Coder-480B-A35B-Instruct model by integrating comprehensive instructions for its deployment and performance evaluation on AMD MI300X GPUs. The added guide covers the entire process from Docker environment preparation to running benchmarks, ensuring users can effectively leverage AMD hardware for this model.

Highlights

  • AMD GPU Support Documentation: Added a new section to the Qwen3-Coder-480B-A35B.md file detailing the steps required to install and run the Qwen3-Coder-480B-A35B-Instruct models on AMD MI300X GPUs.
  • Docker Environment Setup: Provided instructions for pulling the rocm/vllm-dev:nightly Docker image and launching it with the necessary privileges and device mappings for AMD GPUs.
  • vLLM Server Configuration: Included a sample command for starting the vLLM online serving with specific environment variables and parameters tailored for the Qwen3-Coder model, including SAFETENSORS_FAST_GPU=1 and NCCL_MIN_NCHANNELS=112.
  • Benchmarking Instructions: Detailed steps for running a benchmark script inside the Docker container using vllm bench serve with parameters like random-input-len, random-output-len, and request-rate.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a helpful guide for running the Qwen3-Coder model on AMD GPUs. The instructions are clear and cover the necessary steps from environment setup to benchmarking. My review focuses on improving the formatting and readability of the new documentation, including suggestions for breaking up long commands, ensuring consistent terminology, and removing excessive whitespace. These changes will make the guide easier for users to follow.

Comment on lines +134 to +135


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are three consecutive blank lines here. To improve formatting and make the document more compact, please reduce this to a single blank line by removing two of them.


Sample Command
```shell

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This blank line within the shell command block is unnecessary and can be removed to make the code block more compact.

--trust-remote-code

```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are multiple blank lines here. Please remove the extra one to improve formatting.

Open a new terminal and run the following command to execute the benchmark script inside the container.
```shell
docker exec -it Qwen3-Coder-480B-A35B-Instruct vllm bench serve \
--model "Qwen/Qwen3-Coder-480B-A35B-Instruct" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The model name is quoted here, but it's not quoted in the vllm serve command in Step 3. For consistency, it's better to remove the quotes as they are not necessary in this case.

Suggested change
--model "Qwen/Qwen3-Coder-480B-A35B-Instruct" \
--model Qwen/Qwen3-Coder-480B-A35B-Instruct \

Comment on lines +188 to +189


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These extra blank lines at the end of the document can be removed.

```



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line contains trailing whitespace, which should be removed.

haic0 and others added 4 commits December 12, 2025 11:46
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant