Conversation
Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
Summary of ChangesHello @haic0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation for the DeepSeek-V3.1 model by providing comprehensive instructions for deploying and benchmarking it on AMD MI300X GPUs. It outlines the necessary steps for setting up the Docker environment, configuring the vLLM server, and executing performance benchmarks, thereby extending the model's usability to AMD hardware. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds documentation for running DeepSeek-V3.1 on AMD GPUs. The instructions are clear and cover the necessary steps from environment setup to benchmarking. I've added a couple of suggestions to improve the documentation. One is a high-severity recommendation to add a security warning about the docker run command, which uses privileged flags. The other is a medium-severity suggestion to improve the readability of the instructions for starting the vLLM server. Overall, this is a valuable addition.
DeepSeek/DeepSeek-V3_1.md
Outdated
| ```shell | ||
| docker pull rocm/vllm-dev:nightly | ||
| ``` | ||
| Launch the ROCm vLLM docker: |
There was a problem hiding this comment.
The docker run command uses --privileged and --security-opt seccomp=unconfined, which grant the container extensive permissions on the host system. This poses a significant security risk. It's important to warn users about this. Consider adding a warning note.
| Launch the ROCm vLLM docker: | |
| Launch the ROCm vLLM docker: | |
| > [!WARNING] | |
| > The following command includes `--privileged` and `--security-opt seccomp=unconfined` flags, which grant extensive permissions to the container. Only use this configuration in a trusted development environment. |
DeepSeek/DeepSeek-V3_1.md
Outdated
|
|
||
| Run the vllm online serving | ||
|
|
||
|
|
||
| Sample Command |
There was a problem hiding this comment.
833af7d to
d4ef969
Compare
…1 AMD GPU support Tested and verified on 8x MI300X: - vLLM server starts successfully - Benchmark passed: 16/16 requests, 110 tok/s output throughput Co-authored-by: billishyahao <bill.he@amd.com> Co-authored-by: yueyuan <yueyuan@amd.com> Signed-off-by: Yuan Yue <yueyuan@amd.com>
d4ef969 to
82b9ff8
Compare
- Replace Docker-based installation with uv venv approach - Simplify to essential AMD-specific environment variables only - Use latest stable ROCm wheel: https://wheels.vllm.ai/rocm/ - Follow Qwen3-Next.md format with Step 1, 2, 3 structure - Remove unnecessary flags: gpu-memory-utilization, disable-log-requests, etc. Co-authored-by: billishyahao <bill.he@amd.com> Co-authored-by: yueyuan <yueyuan@amd.com> Signed-off-by: Yuan Yue <yueyuan@amd.com>
33b68f3 to
24a9771
Compare
| vllm serve deepseek-ai/DeepSeek-V3.1 \ | ||
| --tensor-parallel-size 8 \ | ||
| --enable-expert-parallel \ | ||
| --served-model-name ds31 |
There was a problem hiding this comment.
we have to remove this --served-model-name argument, it is conflicting with the benchmark command.
Moreover, the vllm serve --model <model path> expect <model path> to be a valid path (either a huggingface hub name, or a local path) where it can get the tokenizer values. So we cannot use custom served-model-name.
No description provided.