Skip to content

Update Seed-OSS-36B.md for AMD GPU #157

Open
haic0 wants to merge 8 commits intovllm-project:mainfrom
haic0:patch-15
Open

Update Seed-OSS-36B.md for AMD GPU #157
haic0 wants to merge 8 commits intovllm-project:mainfrom
haic0:patch-15

Conversation

@haic0
Copy link
Contributor

@haic0 haic0 commented Dec 11, 2025

No description provided.

Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @haic0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Seed-OSS-36B.md documentation by integrating a new, comprehensive guide for deploying and benchmarking Seed-OSS-36B-Instruct models on AMD MI300X GPUs. The added section provides a step-by-step walkthrough, ensuring users can effectively leverage AMD hardware for these models, covering the entire workflow from environment preparation to benchmarking.

Highlights

  • AMD GPU Support Documentation: A new section has been added to the Seed-OSS-36B.md file, providing comprehensive instructions for installing and running Seed-OSS-36B-Instruct models on AMD MI300X GPUs.
  • Docker Environment Setup: Detailed steps are now included for preparing the Docker environment, specifically for pulling and launching the rocm/vllm-dev:nightly Docker image.
  • vLLM Server Configuration: Sample commands are provided for starting the vLLM server, including necessary environment variables and parameters tailored for the Seed-OSS-36B-Instruct model on AMD hardware.
  • Benchmarking Guide: Instructions for executing a benchmark script inside the Docker container using vllm bench serve have been added to facilitate performance testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds instructions for running the Seed-OSS-36B model on AMD GPUs. The changes are clear and provide step-by-step guidance. I've identified a few minor formatting issues in the new documentation, such as extra whitespace, inconsistent formatting in code blocks, and trailing blank lines. Addressing these will improve the clarity and user experience for those following the guide. My detailed comments provide specific suggestions for these improvements.

Comment on lines +250 to +252



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These trailing blank lines and whitespace at the end of the file are unnecessary and should be removed. It's a good practice to have a single newline at the end of a file for cleaner formatting.

haic0 and others added 7 commits December 12, 2025 12:25
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: haic0 <149741444+haic0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants