Conversation
-unsubmitted-data
…at use BuildingsTable component
…ut of date data and never reported statuses mutually exclusive
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I have just noticed that a lot of the time the "never reported" buildings also commonly flag as "electric only" and I should probably change that so that doesn't happen. I also will add screenshots to the updated features and will also request some clarification on the text that should be in the building never submitted infographic. |
|
I also noticed that there's warnings for data discrepancies over the report card. I should probably do the same thing for when the building never submitted. |
|
@JonHunt1995 - this PR is in draft, but did you mean for me to review it? If so, just hit "Ready for review" at the bottom next time or tag me! |
@vkoves I think this PR is ready for review. I believe the failing CI/CD tests are due to the updates on the data pipeline. I may have to make some adjustments to the text I wrote for some warning components and make additional logic changes to make the "building never submitted" status mutually exclusive with other statuses such as "100% electric". Let me know your thoughts! |
|
@JonHunt1995 - quick spot, looking at the homepage the most emissions intense section is off, I think because you're filtering by only latest year submitted. We don't do that because it meant really bad buildings that skip reporting no longer get any call outs |
| if latest_year_only: | ||
| cleaned_data = get_buildings_with_ghg_intensity(building_data) | ||
| cleaned_data = get_submitted_data(cleaned_data) | ||
| # cleaned_data = get_buildings_with_ghg_intensity(building_data) |
There was a problem hiding this comment.
Is this meant to be commented out? If you don't want it anymore, delete it!
|
@JonHunt1995 - could you add some sample buildings to reference and maybe a screenshot to the description? I feel like we had talked about some buildings but off-hand I can't find any 😅 |
2 participants
Description
Updated data pipeline to no longer filter out buildings that have never reported data to the city. Added
❌emoji to denote buildings that have never reported data, and added an infographic for building details as well. Finally, added logic to "Out of Date Data" to be mutually exclusive with "Building Never Submitted Data" status.Fixes #170
Testing Instructions
I looked at a few buildings that had been marked as "❌" to check to see if they don't currently show up with the live website and that the years reported report card matches up with the "Building Never Submitted Data" status.
Checklist:
Data Update (if applicable):