Open
Conversation
…irective arg builder
Collaborator
|
Thanks @KitoC - apologies for not having looked at this, I'm not doing much JS at the moment! I will try to take a look in the next week or so :) |
Collaborator
|
Hi @KitoC - just had a look at this (again, apologies for how long this has taken, particularly as it was your first contribution!!). I think we need something a bit more generic than tie-ing it to a specific directive name. I wonder if we should just add an extra key in the directive args object, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Apollo rest-link uses the @rest directive to to determine if it is a rest query/mutation with a range of config passed into the args of the directive ( e.g.
@rest(path: "/foo")). Currently if you want to use both__directiveand__argsfor the same key,json-to-graphql-querywill generate the following directive and arg shapefoo @rest(directive: args) (real: args). Apollo requires you to construct it like this -foo (real: args) @rest(directive: args).Additionally, as far as I am aware, there doesn't seem to be any reason for stripping the quotes
"from the args passed into the directive. Currently if you want to have a string in the directive args you cannot.Solution
This is my first time contributing to open source projects so if there is anything I missed please let me know 😁 👍 .