fix: memory leak in dismissal polling due to undrained autoreleasepool#65
Open
A0150315 wants to merge 1 commit intovjeantet:masterfrom
Open
fix: memory leak in dismissal polling due to undrained autoreleasepool#65A0150315 wants to merge 1 commit intovjeantet:masterfrom
A0150315 wants to merge 1 commit intovjeantet:masterfrom
Conversation
deliveredNotifications returns new NSArray+NSUserNotification copies on each call. On the GCD background thread used by startDismissalPolling, there is no RunLoop to automatically drain the autorelease pool, causing continuous memory growth (~5 calls/sec) while the notification is idle. Changes: - Wrap polling loop body in autoreleasepool to drain ObjC temporaries - Add pollingCancelled flag for clean cancellation - Use NSLock in outputAndExit to prevent race conditions between polling thread, timeout handler, and user activation callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deliveredNotifications returns new NSArray+NSUserNotification copies on each call. On the GCD background thread used by startDismissalPolling, there is no RunLoop to automatically drain the autorelease pool, causing continuous memory growth (~5 calls/sec) while the notification is idle.
Changes: