Fix syntax and data errors in four 8-bit fonts.#7
Open
jdebp wants to merge 4 commits intoviznut:mainfrom
Open
Conversation
added 4 commits
June 8, 2023 08:40
Two fonts were not marked as "8x8". assemble.pl complained about their font data not being 8 by 16.
assemble.pl was generating an odd error because of "E+" in place of "U+".
Character data were 7 by 8, causing assemble.pl to complain.
The 'u' employed for 'u' with diacritics was erroneously a 'v' in the -mcr variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the unscii assemble.pl script against these four fonts reveals two missing 8x8 tags, an erroneous "E+" instead of a "U+", and one glyph that is 7x8 instead of 8x8.
Experimenting with -mcr on its own revealed that was erroneously using 'v' for 'u' with diacritics.