Revised for MP5 with suggestions from feedback and start menu #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeunginLyu
reviewed
Dec 11, 2017
|
|
||
| # main event loop | ||
| while 1: | ||
| while True: |
There was a problem hiding this comment.
okay while True is better than while 1 but it still does not tell anything about the state of the while loop. I suggest using while running = True or while playing
SeunginLyu
reviewed
Dec 11, 2017
| P1_stamina_bar = StaminaBar(self.screen,25,"WHITE") | ||
| P2_stamina_bar = StaminaBar(self.screen,350,"RED") | ||
| P1_stamina_bar = StaminaBar(self.screen, P1_STAMINA_BAR_OFFSET, 'WHITE') | ||
| P2_stamina_bar = StaminaBar(self.screen, self.width - P2_STAMINA_BAR_OFFSET, 'RED') |
There was a problem hiding this comment.
awesome!! all CAPS constants are so much cleaner
SeunginLyu
reviewed
Dec 11, 2017
| LEVEL_OFFSETS = {'ground': 0, | ||
| 'first': 25, | ||
| 'second': 50, | ||
| } |
There was a problem hiding this comment.
+1 +1 +1, this is so much easier to maintain
SeunginLyu
reviewed
Dec 11, 2017
SeunginLyu
left a comment
SeunginLyu
left a comment
There was a problem hiding this comment.
Nice job cleaning up the adding new features and fixing the bugs. The documentation certainly improved and the code has generally got much cleaner. Congratulations on completing your final mini project for Softdes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.