Open
Conversation
johnnyomair
commented
Mar 19, 2026
| OAUTH2_PROXY_SKIP_PROVIDER_BUTTON=true | ||
| OAUTH2_PROXY_EMAIL_DOMAINS="*" | ||
| OAUTH2_PROXY_SCOPE=openid offline_access email profile | ||
| OAUTH2_PROXY_SCOPE="openid offline_access email profile" |
Collaborator
Author
There was a problem hiding this comment.
This change fixes the following error:
demo-docker: .env: line 114: offline_access: command not found
Ben-Ho
previously approved these changes
Mar 19, 2026
nsams
reviewed
Mar 19, 2026
dev-pm.config.ts
Outdated
| { | ||
| name: "demo-docker", | ||
| script: "pnpm run dev:docker-compose up", | ||
| script: "set -a; [ -f .env ] && . .env; [ -f .env.local ] && . .env.local; [ -f .env.secrets ] && . .env.secrets; set +a; docker compose up", |
Member
There was a problem hiding this comment.
.env is always there
Suggested change
| script: "set -a; [ -f .env ] && . .env; [ -f .env.local ] && . .env.local; [ -f .env.secrets ] && . .env.secrets; set +a; docker compose up", | |
| script: "set -a; . .env; [ -f .env.local ] && . .env.local; [ -f .env.secrets ] && . .env.secrets; set +a; docker compose up", |
and since https://github.com/vivid-planet/comet/blob/main/install.sh#L9 even .env.local always exists, so maybe it could even be simplified to:
Suggested change
| script: "set -a; [ -f .env ] && . .env; [ -f .env.local ] && . .env.local; [ -f .env.secrets ] && . .env.secrets; set +a; docker compose up", | |
| script: "set -a; . .env; . .env.local; . .env.secrets; set +a; docker compose up", |
Collaborator
Author
There was a problem hiding this comment.
Updated. Also, removed support for .env.secrets as it doesn't make sense too me.
nsams
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in #5297 causes Docker to fail when stopping the demo-docker process:
demo-docker: Compose Stopping Gracefully Stopping... press Ctrl+C again to force demo-docker: got 3 SIGTERM/SIGINTs, forcefully exiting demo-docker: ELIFECYCLE Command failed with exit code 1. demo-docker: [dev-pm] process stoppedAccording to Claude, this is related to PNPM's shutdown handling.
The only workaround I (and Claude) could find was to not use PNPM and
dotenv.Then Docker can shutdown gracefully: