Skip to content

Demo: fix stopping Docker#5344

Open
johnnyomair wants to merge 3 commits intomainfrom
demo-fix-stopping-docker
Open

Demo: fix stopping Docker#5344
johnnyomair wants to merge 3 commits intomainfrom
demo-fix-stopping-docker

Conversation

@johnnyomair
Copy link
Collaborator

The change in #5297 causes Docker to fail when stopping the demo-docker process:

demo-docker:  Compose Stopping Gracefully Stopping... press Ctrl+C again to force
demo-docker: got 3 SIGTERM/SIGINTs, forcefully exiting
demo-docker:  ELIFECYCLE  Command failed with exit code 1.
demo-docker: [dev-pm] process stopped

According to Claude, this is related to PNPM's shutdown handling.
The only workaround I (and Claude) could find was to not use PNPM and dotenv.
Then Docker can shutdown gracefully:

demo-docker:  Compose Stopping Gracefully Stopping... press Ctrl+C again to force
demo-docker:  Container core-v9-postgres-1 Stopping 
demo-docker:  Container core-v9-jaeger-1 Stopping 
demo-docker:  Container core-v9-imgproxy-1 Stopping 
demo-docker:  Container core-v9-mailpit-1 Stopping 
demo-docker:  Container core-v9-valkey-1 Stopping 
demo-docker:  Container core-v9-jaeger-1 Stopped 
demo-docker:  Container core-v9-imgproxy-1 Stopped 
demo-docker:  Container core-v9-postgres-1 Stopped 
demo-docker:  Container core-v9-valkey-1 Stopped 
demo-docker:  Container core-v9-mailpit-1 Stopped 
demo-docker: 
demo-docker: [dev-pm] process stopped

@johnnyomair johnnyomair requested review from Ben-Ho and nsams March 19, 2026 10:01
@johnnyomair johnnyomair self-assigned this Mar 19, 2026
OAUTH2_PROXY_SKIP_PROVIDER_BUTTON=true
OAUTH2_PROXY_EMAIL_DOMAINS="*"
OAUTH2_PROXY_SCOPE=openid offline_access email profile
OAUTH2_PROXY_SCOPE="openid offline_access email profile"
Copy link
Collaborator Author

@johnnyomair johnnyomair Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes the following error:

demo-docker: .env: line 114: offline_access: command not found

Ben-Ho
Ben-Ho previously approved these changes Mar 19, 2026
dev-pm.config.ts Outdated
{
name: "demo-docker",
script: "pnpm run dev:docker-compose up",
script: "set -a; [ -f .env ] && . .env; [ -f .env.local ] && . .env.local; [ -f .env.secrets ] && . .env.secrets; set +a; docker compose up",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.env is always there

Suggested change
script: "set -a; [ -f .env ] && . .env; [ -f .env.local ] && . .env.local; [ -f .env.secrets ] && . .env.secrets; set +a; docker compose up",
script: "set -a; . .env; [ -f .env.local ] && . .env.local; [ -f .env.secrets ] && . .env.secrets; set +a; docker compose up",

and since https://github.com/vivid-planet/comet/blob/main/install.sh#L9 even .env.local always exists, so maybe it could even be simplified to:

Suggested change
script: "set -a; [ -f .env ] && . .env; [ -f .env.local ] && . .env.local; [ -f .env.secrets ] && . .env.secrets; set +a; docker compose up",
script: "set -a; . .env; . .env.local; . .env.secrets; set +a; docker compose up",

Copy link
Collaborator Author

@johnnyomair johnnyomair Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Also, removed support for .env.secrets as it doesn't make sense too me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants