Skip to content

Fix RadioGroupField props type: use RadioGroupFieldProps instead of SelectFieldProps#5326

Merged
manuelblum merged 2 commits intocom-2900/add-crud-skillsfrom
copilot/sub-pr-5323-another-one
Mar 16, 2026
Merged

Fix RadioGroupField props type: use RadioGroupFieldProps instead of SelectFieldProps#5326
manuelblum merged 2 commits intocom-2900/add-crud-skillsfrom
copilot/sub-pr-5323-another-one

Conversation

Copy link
Contributor

Copilot AI commented Mar 16, 2026

The enum-05-radio-group-field.md skill template incorrectly typed the props using SelectFieldProps (a different component's API) instead of RadioGroupFieldProps.

Changes

  • Template & concrete example: Replace Omit<SelectFieldProps<...>, "options"> with Omit<RadioGroupFieldProps<...>, "options"> and update the import accordingly
  • Stale comment: Remove "Same shape as SelectField, swap..." note that no longer applies
// Before
import { RadioGroupField, type SelectFieldProps } from "@comet/admin";
type LocationStatusRadioGroupFieldProps = Omit<SelectFieldProps<LocationStatusFormState>, "options">;

// After
import { RadioGroupField, type RadioGroupFieldProps } from "@comet/admin";
type LocationStatusRadioGroupFieldProps = Omit<RadioGroupFieldProps<LocationStatusFormState>, "options">;

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…electFieldProps

Co-authored-by: manuelblum <6098356+manuelblum@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback on adding comet-crud Agent skills Fix RadioGroupField props type: use RadioGroupFieldProps instead of SelectFieldProps Mar 16, 2026
Copilot AI requested a review from manuelblum March 16, 2026 15:43
@manuelblum manuelblum marked this pull request as ready for review March 16, 2026 17:27
@manuelblum manuelblum merged commit 2c01157 into com-2900/add-crud-skills Mar 16, 2026
2 checks passed
@manuelblum manuelblum deleted the copilot/sub-pr-5323-another-one branch March 16, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants