Demo: remove SITE_URL (and BREVO_REDIRECT_URL_FOR_IMPORT) from env#5322
Open
Demo: remove SITE_URL (and BREVO_REDIRECT_URL_FOR_IMPORT) from env#5322
Conversation
As we don't have a single site url that variable should not be used, as it only points to the first site. Use siteConfig instead. Also remove BREVO_REDIRECT_URL_FOR_IMPORT and get the url from siteConfig - for the correct one.
nsams
commented
Mar 16, 2026
| "browser:demo:api": "dotenv -- sh -c 'open-cli $API_URL/graphql'", | ||
| "browser:demo:admin": "dotenv -- sh -c 'open-cli $ADMIN_URL'", | ||
| "browser:demo:site": "dotenv -- sh -c 'open-cli $SITE_URL'", | ||
| "browser:demo:site": "dotenv -- sh -c 'open-cli http://localhost:$SITE_PORT'", |
Member
Author
There was a problem hiding this comment.
I decided to not keep SITE_URL just for this script
johnnyomair
previously approved these changes
Mar 16, 2026
Collaborator
|
Please resolve conflicts. |
johnnyomair
previously approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we don't have a single site url that variable should not be used, as it only points to the first site. Use siteConfig instead.
Also remove BREVO_REDIRECT_URL_FOR_IMPORT and get the url from siteConfig - for the correct one.