Skip to content

Docs: add A11y page to coding guidelines#5302

Open
jamesricky wants to merge 1 commit intomainfrom
coding-guidelines-a11y
Open

Docs: add A11y page to coding guidelines#5302
jamesricky wants to merge 1 commit intomainfrom
coding-guidelines-a11y

Conversation

@jamesricky
Copy link
Contributor

No description provided.

@auto-assign auto-assign bot requested a review from johnnyomair March 12, 2026 10:16
@jamesricky jamesricky requested review from stekalt and removed request for johnnyomair March 12, 2026 10:16
@jamesricky jamesricky force-pushed the coding-guidelines-a11y branch from 1c06b64 to 56e8578 Compare March 12, 2026 10:20
@johnnyomair johnnyomair self-requested a review March 12, 2026 10:32
@johnnyomair johnnyomair changed the title Add A11y page to Coding Guidelines Docs: add A11y page to coding guidelines Mar 12, 2026
@stekalt
Copy link
Contributor

stekalt commented Mar 18, 2026

Here are some points I think are missing:

  • Skip links: the has to be a skip link implemented to skip the main navigation
  • Focus trap for dialogs/modals: Keyboard accessibility is mentioned, but it’s not stated that focus must be trapped inside an open dialog and restored to a meaningful element when the dialog is closed.
  • ARIA roles and attributes: ARIA is only mentioned in the context of labels, but other aria-attributes that are somewhat more important also should be considered, e.g. aria-label in buttons with only an icon inside, aria-expanded and aria-expanded in accordions etc. Also it should be mention to use ARIA only when necessary and always correctly.
  • Color not as the only means of conveying information: WCAG requires that color alone must not be used to convey information (e.g. link styling, states, error messages).
  • Zoom: content must also remain usable at 200% zoom
  • Testing: Maybe it would also be good to add a short section about manual and automated testing (keyboard-only navigation, screen reader checks, color-blindness simulation, tools like getstark.co).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants