Fix ContentOverflow "In DataGrid" story: rows rendering at wrong height#5284
Draft
Fix ContentOverflow "In DataGrid" story: rows rendering at wrong height#5284
Conversation
…f rowHeight Co-authored-by: jamesricky <6264317+jamesricky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix vertical alignment issue in DataGrid with ContentOverflow
Fix ContentOverflow "In DataGrid" story: rows rendering at wrong height
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Comet theme sets a global
getRowHeightinMuiDataGriddefaultProps(returning 60px for standard density). The story usedrowHeight={100}, butgetRowHeightandrowHeightare separate props —getRowHeightwins per-row, so rows were 60px, not 100px.ContentOverflowrelies onheight: 100%internally, so it was undersized and misaligned within the cell.Fix
rowHeight={100}withgetRowHeight={() => 100}in theInDataGridstory. An explicitgetRowHeightprop on the component overrides the theme'sdefaultProps.getRowHeight, ensuring rows are actually 100px.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.