Skip to content

Demo Admin Server: Pin @types/node dependency#5197

Merged
johnnyomair merged 1 commit intomainfrom
claude/add-types-node-v24-sXoIr
Feb 23, 2026
Merged

Demo Admin Server: Pin @types/node dependency#5197
johnnyomair merged 1 commit intomainfrom
claude/add-types-node-v24-sXoIr

Conversation

@johnnyomair
Copy link
Collaborator

@johnnyomair johnnyomair commented Feb 19, 2026

Description

Noticed this while reviewing vivid-planet/comet-starter#1221: Since we don't have a direct dependency on @types/node in the server, lock file maintenance would upgrade it to the latest version. Since we're using Node 24 in production, I think it's a good idea to ensure that we have the correct types, even if we're not using them (yet).

https://claude.ai/code/session_016UD4tnxkvuZZn3qEMghBMZ

@johnnyomair johnnyomair self-assigned this Feb 19, 2026
@johnnyomair johnnyomair changed the title Add @types/node to devDependencies in demo admin server Demo Admin Server: Pin @types/node dependency Feb 19, 2026
@johnnyomair johnnyomair marked this pull request as ready for review February 19, 2026 11:34
@johnnyomair johnnyomair added the needs-starter-pr Change in Demo that needs to be changed in Starter as well. label Feb 23, 2026
@johnnyomair johnnyomair merged commit 8f71018 into main Feb 23, 2026
12 checks passed
@johnnyomair johnnyomair deleted the claude/add-types-node-v24-sXoIr branch February 23, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-starter-pr Change in Demo that needs to be changed in Starter as well.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants