Port API lint improvements from comet PR #5136#1359
Draft
Conversation
…t, lint:generated-files-not-modified, and MIKRO_ORM_NO_CONNECT support Co-authored-by: nsams <50764+nsams@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update API to comet-starter framework
Port API lint improvements from comet PR #5136
Mar 19, 2026
nsams
reviewed
Mar 19, 2026
nsams
reviewed
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports vivid-planet/comet#5136 to comet-starter. Adds CI-time verification that the API NestJS AppModule can be instantiated (DI is wired correctly) and that generated files (
schema.gql,block-meta.json) are up to date.lint:api-can-start: Runsconsole.ts --helpwithMIKRO_ORM_NO_CONNECT=trueto validate AppModule + GraphQL schema generation without a databaselint:generated-files-not-modified: Checksschema.gql,block-meta.json, andsrc/**/generated/*for uncommitted diffslint/lint:ci:api-can-startadded to parallel lint;generated-files-not-modifiedruns sequentially after (depends on regenerated schema)ormconfig.ts: Addedconnect: process.env.MIKRO_ORM_NO_CONNECT !== "true"to support DB-less instantiationAcceptance criteria
Screenshots/screencasts
N/A — CI/lint-only changes, no UI impact.
Open TODOs/questions
Further information
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
github.com (HTTP Only)/usr/bin/ssh /usr/bin/ssh -o SendEnv=GIT_PROTOCOL git@github.com git-upload-pack 'vivid-planet/comet.git'(packet block)/usr/bin/ssh /usr/bin/ssh -o SendEnv=GIT_PROTOCOL git@github.com git-upload-pack 'vivid-planet/comet.git' submodules | head -n 10(packet block)iojs.org/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -(dns block)If you need me to access, download, or install something from one of these locations, you can either:
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.