Skip to content

Port API lint improvements from comet PR #5136#1359

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/update-api-to-comet-starter
Draft

Port API lint improvements from comet PR #5136#1359
Copilot wants to merge 4 commits intomainfrom
copilot/update-api-to-comet-starter

Conversation

Copy link
Contributor

Copilot AI commented Mar 19, 2026

Description

Ports vivid-planet/comet#5136 to comet-starter. Adds CI-time verification that the API NestJS AppModule can be instantiated (DI is wired correctly) and that generated files (schema.gql, block-meta.json) are up to date.

  • lint:api-can-start: Runs console.ts --help with MIKRO_ORM_NO_CONNECT=true to validate AppModule + GraphQL schema generation without a database
  • lint:generated-files-not-modified: Checks schema.gql, block-meta.json, and src/**/generated/* for uncommitted diffs
  • lint/lint:ci: api-can-start added to parallel lint; generated-files-not-modified runs sequentially after (depends on regenerated schema)
  • ormconfig.ts: Added connect: process.env.MIKRO_ORM_NO_CONNECT !== "true" to support DB-less instantiation

Acceptance criteria

Screenshots/screencasts

N/A — CI/lint-only changes, no UI impact.

Open TODOs/questions

  • [ ]

Further information

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • github.com (HTTP Only)
    • Triggering command: /usr/bin/ssh /usr/bin/ssh -o SendEnv=GIT_PROTOCOL git@github.com git-upload-pack 'vivid-planet/comet.git' (packet block)
    • Triggering command: /usr/bin/ssh /usr/bin/ssh -o SendEnv=GIT_PROTOCOL git@github.com git-upload-pack 'vivid-planet/comet.git' submodules | head -n 10 (packet block)
  • iojs.org
    • Triggering command: /usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o - (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

…t, lint:generated-files-not-modified, and MIKRO_ORM_NO_CONNECT support

Co-authored-by: nsams <50764+nsams@users.noreply.github.com>
Copilot AI changed the title [WIP] Update API to comet-starter framework Port API lint improvements from comet PR #5136 Mar 19, 2026
Copilot AI requested a review from nsams March 19, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants