PoC: Crud skill test 02 product category#1345
Draft
manuelblum wants to merge 10 commits intocrud-skill-test-01-productfrom
Draft
PoC: Crud skill test 02 product category#1345manuelblum wants to merge 10 commits intocrud-skill-test-01-productfrom
manuelblum wants to merge 10 commits intocrud-skill-test-01-productfrom
Conversation
johnnyomair
reviewed
Mar 17, 2026
Comment on lines
+47
to
+54
| const populate: string[] = []; | ||
| if (fields?.includes("category")) { | ||
| populate.push("category"); | ||
| } | ||
| if (populate.length > 0) { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| options.populate = populate as any; | ||
| } |
Collaborator
There was a problem hiding this comment.
We won't need populate in Comet v9, we'll have to remove it from the skill then.
| import { ProductCategoryResolver } from "./product-category.resolver"; | ||
|
|
||
| @Module({ | ||
| imports: [MikroOrmModule.forFeature([ProductCategory])], |
Collaborator
There was a problem hiding this comment.
The skill doesn't use repositories, right? Then it shouldn't be necessary to have those MikroOrmModule.forFeature calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample PR showcasing how Claude (Opus 4.6) implements full-stack CRUD from a spec file using Comet skills. The entire
implementation — API entity, admin UI, relation wiring, filtering — was generated from
specs/product/02-product-category.md. This also includes updating the existing Product entity with a category relationand filter.
What's implemented
parentCategoryManyToOne, position field for ordering, MikroORM migration, NestJS module registrationProductCategoryValidationErrorCodeenumupdateProductCategorymutation. Columns: name, slug, parentCategory (shows parent name). No search/filter per specexcludeId). Slug uniqueness errors shown inline/product-categoriescategoryManyToOne on Product entity, migration,@ResolveField, conditional populate infindAll, category field in Product form (AsyncAutocompleteField in Details fieldset)ManyToOneFilterfilteringSpec
See
specs/product/02-product-category.mdfor the full requirements.