Fix race condition in email campaign updates for past-scheduled campaigns

[Copilot]

Description

Email campaigns with past scheduled times could incorrectly block updates even when not yet sent. Two issues contributed to this problem:

1. The local sendingState check didn't account for the delay between schedule time and actual Brevo execution
2. The @MinDate(new Date()) validator was evaluated once at server startup, causing stale date validation

Solution:

• Query Brevo API for actual campaign status when scheduledAt < now:
  • If Brevo reports SENT → sync local state, reject update
  • If Brevo reports SCHEDULED/DRAFT → sync local state, allow update
• Create custom @IsFutureDate() validator to evaluate date at validation time instead of server startup (replacing @MinDate which doesn't support function arguments in class-validator 0.13.1)

This mirrors the fix from vivid-planet/comet#5155.

Changes:

• Split SENT validation into immediate check and past-scheduled check in email-campaign.resolver.ts
• Added brevoApiCampaignsService.loadBrevoCampaignById() call for campaigns with scheduledAt < now
• Update local sendingState based on Brevo response before throwing errors
• Created custom @IsFutureDate() validator in email-campaign-input.factory.ts for runtime date validation
• Exported IsFutureDate validator in package index for reusability
• Added changeset for version tracking

Example

// Campaign scheduled for yesterday but Brevo hasn't sent it yet
// Before: Would throw "Cannot update email campaign that has already been sent"
// After: Queries Brevo, gets SCHEDULED status, allows update
await updateEmailCampaign(id, { subject: "Updated subject" });

[x] I have verified if my change requires an example

Screenshots/screencasts

N/A

Changeset

[x] I have verified if my change requires a changeset

Related tasks and documents

Applies changes from https://github.com/vivid-planet/comet/pull/5155/changes

Open TODOs/questions

None

Further information

Pre-existing TypeScript compilation errors in newsletter-image.block.ts and brevo-api-campaigns.service.ts are unrelated to these changes.

The custom @IsFutureDate() validator was necessary because class-validator 0.13.1 doesn't support passing functions to @MinDate(). The validator maintains the same behavior as @MinDate(new Date()) (using >= comparison) to ensure backward compatibility.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[thomasdax98]

@copilot Also add

• the changeset
• the change to email-campaign-input.factory.ts

from https://github.com/vivid-planet/comet/pull/5155/changes

[Copilot]

@copilot Also add

• the changeset
  ...

Done in commit 5bb6178. Added:

• Changeset file (.changeset/fix-scheduled-campaign-past-date.md)
• Fixed @MinDate validation to use () => new Date() for runtime evaluation in email-campaign-input.factory.ts

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/vivid-planet/comet/pulls/5155/files
  • Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[thomasdax98]

@copilot The MinDate fix doesn't work because it apparently wasn't supported yet by the class-validator version:

Error: packages/api build: src/email-campaign/dto/email-campaign-input.factory.ts(37,22): error TS2345: Argument of type '() => Date' is not assignable to parameter of type 'Date'.
packages/api build: Failed
/home/runner/work/comet-brevo-module/comet-brevo-module/packages/api:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @comet/brevo-api@3.1.5 build: $npm_execpath run clean && tsc -p tsconfig.build.json
Exit status 2
 ELIFECYCLE  Command failed with exit code 2.
Error: Process completed with exit code 2.

Fix this by create a custom IsFutureDate decorator

[Copilot]

@copilot The MinDate fix doesn't work because it apparently wasn't supported yet by the class-validator version:

Error: packages/api build: src/email-campaign/dto/email-campaign-input.factory.ts(3...

Fixed in commit 65ed7ab. Created a custom @IsFutureDate() validator that evaluates the date at runtime instead of class definition time. The validator:

• Uses value >= new Date() to match the original @MinDate behavior
• Allows null/undefined values (controlled by @IsNullable() and @IsUndefinable())
• Is exported in the package index for potential reuse