Draft
Conversation
raphaelblum
force-pushed
the
remove-email-campaigns-factory
branch
from
29758fb to
dd52872
Compare
thomasdax98
reviewed
Nov 20, 2024
| primary: <FormattedMessage id="menu.newsletter.emailCampaigns" defaultMessage="Email campaigns" />, | ||
| route: { | ||
| path: "/newsletter/email-campaigns", | ||
| component: () => <EmailCampaignsPage EmailCampaignContentBlock={EmailCampaignContentBlock} />, |
Member
There was a problem hiding this comment.
Suggested change
| component: () => <EmailCampaignsPage EmailCampaignContentBlock={EmailCampaignContentBlock} />, | |
| render: () => <EmailCampaignsPage EmailCampaignContentBlock={EmailCampaignContentBlock} />, |
This must be render or the component will unmount on every render: https://v5.reactrouter.com/web/api/Route/component#:~:text=That%20means%20if%20you%20provide%20an%20inline%20function%20to%20the%20component%20prop%2C%20you%20would%20create%20a%20new%20component%20every%20render.
| "@comet/brevo-admin": major | ||
| --- | ||
|
|
||
| Remove factory createEmailCampaignsPage |
Member
There was a problem hiding this comment.
Suggested change
| Remove factory createEmailCampaignsPage | |
| Remove `createEmailCampaignsPage` factory |
Contributor
|
This needs a rebase @raphaelblum 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on !147
COM-1053
Description
The factory is not needed. I'd like to simplify creating the EmailCampaignsPage.