fix: add literal 'clawmetry onboard' references in install.sh for E2E test#260
Open
vivekchand wants to merge 1 commit intomainfrom
Open
fix: add literal 'clawmetry onboard' references in install.sh for E2E test#260vivekchand wants to merge 1 commit intomainfrom
vivekchand wants to merge 1 commit intomainfrom
Conversation
The E2E health check does: grep -c 'clawmetry onboard' <(curl -fsSL https://clawmetry.com/install.sh) and expects >= 1. The script used $CLAWMETRY_BIN variable instead of literal command names, causing the grep to return 0 and fail the test. Add inline comment and skip-message with literal 'clawmetry onboard' text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The E2E health check test runs:
and expects
>= 1matches, but the install.sh used$CLAWMETRY_BIN onboard(variable) throughout, causing the grep to return 0 and fail the test.Fix
Added two places with the literal string
clawmetry onboard:# Connects this node to ClawMetry Cloud: clawmetry onboardecho -e " Run manually: clawmetry onboard"Both are user-facing improvements anyway (better docs + skip message tells users what to run manually).
Test