Skip to content

fix: trust localhost in _check_auth + flush /api/flow SSE headers immediately #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivekchand wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: trust localhost in _check_auth + flush /api/flow SSE headers immediately #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15175,6 +15175,10 @@ def _check_auth():
return # Fleet API uses its own X-Fleet-Key authentication
if not request.path.startswith('/api/'):
return # HTML, static, etc. are fine
# Localhost requests are always trusted (health checks, E2E tests, local tooling)
remote = request.remote_addr or ''
if remote in ('127.0.0.1', '::1', 'localhost'):
return
if not GATEWAY_TOKEN:
return jsonify({'error': 'Gateway token not configured. Please set up your gateway token first.', 'needsSetup': True}), 401
token = request.headers.get('Authorization', '').replace('Bearer ', '').strip()
Expand Down Expand Up @@ -16444,6 +16448,11 @@ def generate():
f.seek(0, 2)
jsonl_pos = f.tell()

# Send initial keepalive so SSE response headers are flushed immediately.
# This allows health checks (curl -o /dev/null -w '%{http_code}') to get
# a 200 status without waiting for the first real event.
yield ': keepalive\n\n'

try:
while True:
if time.time() - started > SSE_MAX_SECONDS:
Expand Down
Loading