Open
Conversation
There was a problem hiding this comment.
PR Summary
This PR adds the RocketGuidanceSystem.java file implementing a new processVelocity method with velocity conversion and error handling logic.
- Added
/RocketGuidanceSystem.javato perform casting from double to short. - Includes a check for negative values that can be falsely triggered due to overflow.
- Uses basic exception handling to signal issues in the guidance process.
- The core guidance logic is left as a stub for future enhancements.
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| @@ -0,0 +1,17 @@ | |||
| public class RocketGuidanceSystem { | |||
| public static void processVelocity(double horizontalVelocity) { | |||
| short velocityData = (short) horizontalVelocity; | |||
There was a problem hiding this comment.
logic: Casting from double to short can overflow; if horizontalVelocity > 32767, it becomes negative.
Suggested change
| short velocityData = (short) horizontalVelocity; | |
| if (horizontalVelocity > Short.MAX_VALUE || horizontalVelocity < Short.MIN_VALUE) { | |
| throw new IllegalArgumentException("Velocity value out of range for short: " + horizontalVelocity); | |
| } | |
| short velocityData = (short) horizontalVelocity; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.