Add retry logic to finalizer removal on Routes#8
Merged
tuascloan merged 4 commits intovitistack:mainfrom Mar 20, 2026
Merged
Conversation
To avoid a stacktrace being triggered in logs when someone removes the "securitypolicies.vitistack.io" annotations from their route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple operators have finalizers on the HTTPRoutes and GRPCRoutes.
With multiple updates to the same field we get a race condition where we might not be the first to update the current iteration of the object. This causes the securitypolicy-operator finalizer to remain on the routes which causes routes to be stuck in deleting state.
This PR adds a retry mechanism to finalizer removal on deletion.
For future developmen we should look at using deep-copy with Patch for finalizer like what Envoy does:
https://github.com/envoyproxy/gateway/blob/ffceb4f4cfdf3205fcea4b0018c2d981264335b3/internal/provider/kubernetes/controller.go#L1950