Skip to content

fix: shallow diff between different primitive types #9920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hi-ogawa wants to merge 1 commit into from
Closed

fix: shallow diff between different primitive types #9920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/utils/src/diff/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ export function diff(a: any, b: any, options?: DiffOptions): string | undefined
if (expectedType !== getType(b)) {
const { aAnnotation, aColor, aIndicator, bAnnotation, bColor, bIndicator }
= normalizeDiffOptions(options)
const formatOptions = getFormatOptions(FALLBACK_FORMAT_OPTIONS, options)
// depth can be minimized when diffing different type of values
// since the difference would manifest at the top level.
// this heuristics can help avoiding printing large objects for assertion failure patterns such as:
// expect(shouldBeNullButMaybeHugeObject).toBeFalsy()
const formatOptions = getFormatOptions({ ...FALLBACK_FORMAT_OPTIONS, maxDepth: 1 }, options)
let aDisplay = prettyFormat(a, formatOptions)
let bDisplay = prettyFormat(b, formatOptions)
// even if prettyFormat prints successfully big objects,
Expand Down
Loading