fix: fix suite hook throwing errors for unused auto test-scoped fixture#10035
Open
hi-ogawa wants to merge 7 commits intovitest-dev:mainfrom
Open
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sheremet-va
reviewed
Apr 1, 2026
packages/runner/src/fixture.ts
Outdated
| for (const fixture of registrations.values()) { | ||
| if (fixture.auto || usedProps.has(fixture.name)) { | ||
| // suite hook shouldn't automatically trigger unused test-scoped fixtures | ||
| const auto = fixture.auto && !(options?.suiteHook && fixture.scope === 'test') |
Member
There was a problem hiding this comment.
Can we make the check simpler? fixture.auto && !(options?.suiteHook && fixture.scope === 'test') is vile
Collaborator
Author
There was a problem hiding this comment.
I also argued so hard with Codex 🤣
I thought of some options and ended up with what I have now.
fixture.auto && !(options?.suiteHook && fixture.scope === 'test')fixture.auto && (!options?.suiteHook || fixture.scope !== 'test')fixture.auto && (options?.suiteHook ? fixture.scope !== 'test' : true)options?.suiteHook ? (fixture.auto && fixture.scope !== 'test') : fixture.auto
I might prefer the last one actually.
hi-ogawa
commented
Apr 1, 2026
packages/runner/src/fixture.ts
Outdated
| for (const fixture of registrations.values()) { | ||
| if (fixture.auto || usedProps.has(fixture.name)) { | ||
| // suite hook shouldn't automatically trigger unused test-scoped fixtures | ||
| const auto = fixture.auto && !(options?.suiteHook && fixture.scope === 'test') |
Collaborator
Author
There was a problem hiding this comment.
Yes or no 👀
Suggested change
| const auto = fixture.auto && !(options?.suiteHook && fixture.scope === 'test') | |
| const auto = options?.suiteHook ? (fixture.auto && fixture.scope !== 'test') : fixture.auto |
Member
There was a problem hiding this comment.
@AriPerkkio help us
I think we should do a multi line check
if(!fixture.auto) return false
const isSuiteScope = !!options?.suiteHook
return suiteScope ? fixture.scope !== 'test' : fixture.scope === 'test'Something like this
Member
There was a problem hiding this comment.
fixture.auto && !(options?.suiteHook && fixture.scope === 'test')
😱
I would probably write this into a fully verbose function.
function isAuto(fixture, options) {
if (!fixture.auto) {
return false;
}
if (options.suiteHook && fixture.scope === "test") {
return false;
}
return true;
}
Collaborator
Author
There was a problem hiding this comment.
Switched to isAutoFixture 🚘
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sheremet-va
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.