fix(create-vite): fix "too many arguments error" when using TanStack Router template with pnpm #21618
+47
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
reviewed
Feb 13, 2026
Member
sapphi-red
left a comment
sapphi-red
left a comment
There was a problem hiding this comment.
I cannot test this right now due to TanStack/cli#364, but the description makes sense to me.
Comment on lines
+914
to
+917
| if (pkgManager === 'pnpm') { | ||
| // `npm exec <pkg> -- <args>` uses `--` to split npm flags from package args. `pnpm dlx` doesn't need this separator, and keeping it can break CLIs. | ||
| command = command.replace(/^pnpm dlx (\S+) -- /, 'pnpm dlx $1 ') | ||
| } |
Member
There was a problem hiding this comment.
Can we handle this inside .replace(/^npm exec /, () => { like npm create does?
sapphi-red
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21614
When running:
pnpm create vite@latestand selectingFramework: ReactVariant: TanStack Router, the following occurs:error: too many arguments for 'create'. Expected 1 argument but got 4.The cause is that
getFullCustomCommandcurrently preserves the npm-specific argument separator (--). Forpnpm dlx, the--token is not required and causes subsequent flags (--template,--interactive) to be interpreted as positional arguments by the underlyingcreatecommand.This result in the argument count mismatch.
My proposed fix is adding a pnpm-specific normalization step in:
create-vite/src/index.ts (around line 919)The update transforms:
pnpm dlx <pkg> --<args>into:
pnpm dlx <pkg> <args>this ensures flags are passed correctly and restores the TanStack Router flow.
I manually verified the flow locally. I was not able to run the full test suite in the environment.