fix(rsc): fix virtual "use client" moudle (add resolved-id proxy for virtual modules) #1050
+203
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests for virtual module with 'use client' directive - Add tests for virtual CSS modules in server components - Add tests for virtual CSS modules imported in client components
- Add virtual module with 'use client' directive - Add virtual CSS modules (server and client) - Add @nojs test to verify no FOUC
…t references Virtual modules use \0 prefix internally in Vite, but this cannot be used as an import specifier when generating client reference code. Strip the prefix to allow virtual modules with 'use client' directive to work correctly.
Introduce vitePluginResolvedIdProxy() to handle virtual modules with \0 prefix
in import specifiers and CSS hrefs. This provides a cleaner alternative to
stripping the \0 prefix directly.
Input/Output:
- toResolvedIdProxy("\0virtual:test.css")
=> "virtual:vite-rsc/resolved-id/__x00__virtual:test.css"
- fromResolvedIdProxy("virtual:vite-rsc/resolved-id/__x00__virtual:test.css")
=> "\0virtual:test.css"
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Virtual CSS modules return JS wrapper instead of raw CSS in dev mode. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
hi-ogawa
changed the title
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
hi-ogawa
changed the title
hi-ogawa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
vitePluginResolvedIdProxy()to handle virtual modules with\0prefix in import specifierstoResolvedIdProxy()/fromResolvedIdProxy()/withResolvedIdProxy()helpersuse client, CSS)How it works
Virtual modules in Vite use
\0prefix internally, but this cannot be used as an import specifier. The resolved-id proxy wraps these IDs:Known limitation
Virtual CSS modules don't work in dev mode - Vite adds
?directquery for CSS requests, but the query is lost during proxy resolution, causing JS wrapper to be returned instead of raw CSS. This is marked as TODO in tests.🤖 Generated with Claude Code