Skip to content

Save initial value before focus#4

Open
ktj wants to merge 1 commit intovitalyq:masterfrom
ktj:react-select-fix
Open

Save initial value before focus#4
ktj wants to merge 1 commit intovitalyq:masterfrom
ktj:react-select-fix

Conversation

@ktj
Copy link

@ktj ktj commented Jul 4, 2018

Saving node initial value to variable before focus, so components that clear input on focus work

@ktj ktj force-pushed the react-select-fix branch from 9b10065 to 494d63d Compare July 4, 2018 13:24
@ktj
Copy link
Author

ktj commented Jul 16, 2018

Any input? @vitalyq

@vitalyq
Copy link
Owner

vitalyq commented Jul 17, 2018

Thank you for bringing up the issue. There are some problems with this approach. Ideally, we should get rid of this focus event altogether. I was thinking about monkey patching nodeName on the element or even document.documentMode but further testing is needed.

As a quick fix, please restore the value explicitly or make a wrapper function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants