Open
Conversation
Some NFS clients fail validation when root directory returns inconsistent mtime values on each request. This fix ensures root directory attributes are properly initialized and remain consistent across requests.
vitalif
added a commit
that referenced
this pull request
Sep 24, 2025
vitalif
pushed a commit
that referenced
this pull request
Sep 24, 2025
#95 By submitting this pull request, I accept Vitastor CLA
vitalif
pushed a commit
that referenced
this pull request
Sep 24, 2025
#95 By submitting this pull request, I accept Vitastor CLA
vitalif
pushed a commit
that referenced
this pull request
Sep 24, 2025
#95 By submitting this pull request, I accept Vitastor CLA
vitalif
pushed a commit
that referenced
this pull request
Sep 24, 2025
#95 By submitting this pull request, I accept Vitastor CLA
Owner
|
Hi, thanks!
|
vitalif
added a commit
that referenced
this pull request
Sep 24, 2025
vitalif
pushed a commit
that referenced
this pull request
Sep 24, 2025
#95 By submitting this pull request, I accept Vitastor CLA
vitalif
pushed a commit
that referenced
this pull request
Sep 24, 2025
#95 By submitting this pull request, I accept Vitastor CLA
vitalif
pushed a commit
that referenced
this pull request
Sep 24, 2025
#95 By submitting this pull request, I accept Vitastor CLA
vitalif
pushed a commit
that referenced
this pull request
Sep 24, 2025
#95 By submitting this pull request, I accept Vitastor CLA
vitalif
added a commit
that referenced
this pull request
Sep 24, 2025
New features: - Support UBLK in CSI and make it the default - Add image tree output: `vitastor-cli ls --tree` Bug fixes: - Fix OSDs crashing on localized reads from snapshotted images - Several NFS fixes from github PR #95 - Fix snapshotted bitmap reads not working in EC pools (fix #92) - Fix UBLK reporting incorrect device size (1/8 of actual size), report logical_block_size=4096 - Do not repeer when stopping PEER_CONNECTING osd_clients (increase PG peering stability on failover) - Fix marking PGs as incomplete when peers are unavailable - Fix FS formatter (mkfs and fsck) error handling in CSI (it didn't report mounting errors) - Fix removal of block PVC devices not working in CSI - Do not attempt to free outbound ops in clear_immediate_ops (fix #88) - Add vitastor-disk prepare --dry-run option - Add librdmacm-dev to build-deps - Log has_invalid objects - Do not warn on incomplete+has_invalid PG states as unexpected - Fix OSD reweight values between 0 and 1 not working in monitor - Fix OSD assertion failed: n_subops != sent when all object copies are corrupted - Install ibverbs-providers in vitastor Docker builds - Fix #86 - base64_decode on arm64 O_o - Fix Proxmox 9.0 support (remove some kind of a whitelist added in upstream)
Contributor
Author
The mount client typically determines whether to resend a readdir request to obtain the latest directory listing by comparing the directory's mtime. The most obvious case is that when client A creates a new file in the mounted root directory, client B cannot see the file.
This is because I'm using a go-nfs-client which reads file endings only by checking if the EOF flag is set. For ordinary NFS clients, I indeed haven't encountered any issues. However, this is still a protocol specification, and I hope to resolve it to prevent potential failures in other use cases in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've been testing Vitastor-NFS for a while and have fixed a few bugs.
Looking forward to your review.
By submitting this pull request, I accept Vitastor CLA