Skip to content

fix: don't treat empty data partition as other space in vitastor-disk…#108

Open
Flynn049 wants to merge 1 commit intovitalif:masterfrom
Flynn049:dev
Open

fix: don't treat empty data partition as other space in vitastor-disk…#108
Flynn049 wants to merge 1 commit intovitalif:masterfrom
Flynn049:dev

Conversation

@Flynn049
Copy link
Contributor

@Flynn049 Flynn049 commented Nov 3, 2025

Hi, @vitalif

I found vitastor-disk prepare is not reusing empty data partitions to create OSD as expected when the empty partition takes up very large or the entire disk space. Currently, a disk partition is considered to be of 'other data' if it does not contain any existing OSD's data. But an empty vitastor partition shouldn't be counted as 'other data' since it's reusable, right?

By submitting this pull request, I accept Vitastor CLA

@vitalif
Copy link
Owner

vitalif commented Nov 4, 2025

Hi, it's not reusing them on purpose: who knows what's left there :-) I want the user to explicitly delete the partition if he wants to reuse the space.

@Flynn049
Copy link
Contributor Author

Flynn049 commented Nov 5, 2025

Hi, it's not reusing them on purpose: who knows what's left there :-) I want the user to explicitly delete the partition if he wants to reuse the space.

Even if it's an empty vitastor partition? But why collecting them in use_parts? And current code will actually reuse the partition anyway if it's the only partition on the device, having vitastor type, and consumes less than max_other_percent of the device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants