fix: don't treat empty data partition as other space in vitastor-disk…#108
Open
Flynn049 wants to merge 1 commit intovitalif:masterfrom
Open
fix: don't treat empty data partition as other space in vitastor-disk…#108Flynn049 wants to merge 1 commit intovitalif:masterfrom
Flynn049 wants to merge 1 commit intovitalif:masterfrom
Conversation
Owner
|
Hi, it's not reusing them on purpose: who knows what's left there :-) I want the user to explicitly delete the partition if he wants to reuse the space. |
Contributor
Author
Even if it's an empty vitastor partition? But why collecting them in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @vitalif
I found
vitastor-disk prepareis not reusing empty data partitions to create OSD as expected when the empty partition takes up very large or the entire disk space. Currently, a disk partition is considered to be of 'other data' if it does not contain any existing OSD's data. But an empty vitastor partition shouldn't be counted as 'other data' since it's reusable, right?By submitting this pull request, I accept Vitastor CLA