Fix failing tests #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests use `f:format.html` ViewHelper. This will call the `ContentObjectRenderer::parseFunc`. The default is to use `lib.parseFunc_RTE` as a reference. But this didn't exist within our test setup, leading to errors. We now ensure this path provides some configuration to pass the test.
Our abstract TestCase wasn't named as one, leading to a PHPUnit warning. We therefore adjust the naming to follow the convention and prevent any warning.
As our tests use the database table to verify proper cache handling. The testing framework replaced the defaults with `NullBackend` for performance reasons.
DataProvider need to be static.
Pass necessary arguments to calls. Migrate from unnecessary prophecy to native PHPUnit API.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.