Skip to content

Fix Percent height values, which were using parent width. #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HackerFoo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Percent height values, which were using parent width. #88

HackerFoo wants to merge 3 commits into from

Conversation

@HackerFoo
Copy link

@HackerFoo HackerFoo commented Jun 26, 2021

This fixes a bug where changing the width of a parent affects a child's percentage height value.

@HackerFoo
Copy link
Author

HackerFoo commented Jul 16, 2021

@emilsjolander Any comments? I'd like to get this merged if everything is okay, thanks.

@rparrett rparrett mentioned this pull request May 10, 2022
Closed
@alice-i-cecile alice-i-cecile mentioned this pull request May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HackerFoo