Skip to content

Fix bug when sampling from Orientation model #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suchow wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug when sampling from Orientation model #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions MemModels/Orientation.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
model.prior = @NewPrior;
end
function p = NewPrior(params)
params(whichParameters) = params(whichParameters).*2;
params(whichParameters) = params(whichParameters)./2;
p = model.oldPrior(params);
end

Expand All @@ -60,15 +60,15 @@
model.pdf = @NewPDF;
function p = NewPDF(data, varargin)
if isfield(data, 'errors')
data.errors = data.errors .* 2;
data.errors = data.errors;
end
if isfield(data, 'distractors')
data.distractors = data.distractors .* 2;
data.distractors = data.distractors;
end
if isfield(data, 'changeSize')
data.changeSize = data.changeSize .* 2;
data.changeSize = data.changeSize;
end
varargin(whichParameters) = cellfun(@(x){x.*2}, varargin(whichParameters));
varargin(whichParameters) = cellfun(@(x){x./2}, varargin(whichParameters));
p = model.oldPdf(data, varargin{:});

% To make plotting functions work right:
Expand Down
6 changes: 5 additions & 1 deletion MemUtilities/SampleFromModel.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,11 @@

% Get CDF
if ~r
interpVals = linspace(-180, 180, 1000);
if model.isOrientationModel
interpVals = linspace(-90, 90, 1000);
else
interpVals = linspace(-180, 180, 1000);
end

% Just generate enough samples to fill dims
data.errors = interpVals;
Expand Down