Port IconLayer to WebGPU #9819
Merged
Port IconLayer to WebGPU #9819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Not ready to merge - |
ibgreen
reviewed
Oct 13, 2025
Collaborator
ibgreen
left a comment
ibgreen
left a comment
There was a problem hiding this comment.
- I see you are running into the limited number of vertex buffers - it is quite inconvenient, stricter than WebGL.
- 8 vertex buffers + 10 storage buffers seems to be the limit even on recent macbook https://webgpureport.org/
- We can of course do something on the CPU side to interleave, but it really gets in the way of a simple GPU-buffer-based layer API.
Pessimistress
force-pushed
the
x/icon-layer-webgpu
branch
from
f277692 to
b21ffcb
Compare
ibgreen
approved these changes
Dec 17, 2025
Collaborator
ibgreen
left a comment
ibgreen
left a comment
There was a problem hiding this comment.
Nice work!
Nit: At some point I would like to change shaderAttributes to interleavedAttributes or something and maybe surface it a bit more in docs. That name always throw me off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9504
Change List
Attribute.getBufferLayout()skip sub-attributes with invalid vertex formats