Skip to content

Conversation

@michellequibido-virtusize
Copy link
Contributor

🔗 Related Links

⬅️ As Is

  • Get product types by calling the API.

➡️ To Be

  • Implement product type list locally.
  • Save product type list json file inside the source code and parse.
  • Replace product type API call to product type local

☑️ Checklist

  • Useless comments and/or print etc are removed
  • Unit test are covered
  • Code has been deployed and tested on STG
  • ClickUp ticket status has been updated to production
  • Update CHANGELOG.md with the new changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we have both:

Virtusize/Sources/Resources/productTypes.json
and
Virtusize/Sources/Resources/product_types.json

?

@michellequibido-virtusize michellequibido-virtusize force-pushed the fix/NSDK-365-move-product-types-locally branch from bd19d66 to d798bd6 Compare December 2, 2025 12:58
@michellequibido-virtusize michellequibido-virtusize force-pushed the fix/NSDK-365-move-product-types-locally branch from d798bd6 to 5a2c39d Compare December 4, 2025 12:01
@michellequibido-virtusize michellequibido-virtusize merged commit 711983f into trunk Dec 4, 2025
3 checks passed
@michellequibido-virtusize michellequibido-virtusize deleted the fix/NSDK-365-move-product-types-locally branch December 4, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants