Skip to content

Conversation

@michellequibido-virtusize
Copy link
Contributor

  • modify inpage error return to pass error type to inpageview
  • set inpage view to View.GONE when a product is invalid

🔗 Related Links

⬅️ As Is

Explain the current situation of the code

  • for Android - if the product returns Invalid, it show message error

➡️ To Be

  • if the product returns invalid, hide the entire inpage view/component

☑️ Checklist

  • Useless comments and/or Log.d etc are removed
  • Unit test are covered
  • Code has been deployed and tested on STG
  • ClickUp ticket status has been updated to production
  • Update CHANGELOG.md with the new changes

@michellequibido-virtusize michellequibido-virtusize force-pushed the feature/NSDK-357-Hide-component-for-invalid-product branch 4 times, most recently from 5614a31 to d38ff83 Compare November 17, 2025 15:03
…state

- modify inpage error return to pass error type to inpageview
- set inpage view to View.GONE when a product is invalid
@michellequibido-virtusize michellequibido-virtusize force-pushed the feature/NSDK-357-Hide-component-for-invalid-product branch from d38ff83 to 4470982 Compare November 17, 2025 15:06
@ObranS ObranS merged commit ddcb098 into trunk Nov 17, 2025
3 checks passed
@ObranS ObranS deleted the feature/NSDK-357-Hide-component-for-invalid-product branch November 17, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants