WIP implement NavigateEvent.sourceElement#41
Draft
tchak wants to merge 1 commit intovirtualstate:mainfrom
Draft
Conversation
Contributor
|
Hi, tests are added into the The idea with the test files is that if they exit successfully, its good, exit with an error, its a failing test. For this PR, a test would be added to the There is an anchor event test here, which should be extendable to check that navigation/src/tests/navigation.scope.ts Lines 147 to 175 in 6f66ed2 e.g. ok(anchorEvent.sourceElement, "Expected source element") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/NavigateEvent/sourceElement
This is very much a WIP. I am still trying to figure out how and where to add tests. However, I wanted to open a conversation about it and get your early feedback in case I am going down the wrong path regarding how to implement this.